[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <8a80ec0b-154a-4e6c-8fb8-916f506cd26d@p183>
Date: Sun, 25 Jun 2023 17:07:11 +0300
From: Alexey Dobriyan <adobriyan@...il.com>
To: Lin Ma <linma@....edu.cn>
Cc: steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, simon.horman@...igine.com
Subject: Re: [PATCH v2] net: xfrm: Fix xfrm_address_filter OOB read
> + if (filter->splen >= (sizeof(xfrm_address_t) << 3) ||
> + filter->dplen >= (sizeof(xfrm_address_t) << 3)) {
Please multiply by 8 if you want to multiply by 8.
Should it be "splen > 8 * sizeof()" ?
Powered by blists - more mailing lists