linux-kernel - Re: [PATCH 4/5] dt-bindings: pps: pps-gpio: introduce pulse-width properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43b5fd53-e67a-7d51-3f14-ecd7189ccd7e@linaro.org>
Date:   Sun, 25 Jun 2023 17:48:17 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Eliav Farber <farbere@...zon.com>, giometti@...eenne.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     ronenk@...zon.com, talel@...zon.com, hhhawa@...zon.com,
        jonnyc@...zon.com, itamark@...zon.com, shellykz@...zon.com,
        amitlavi@...zon.com, almogbs@...zon.com
Subject: Re: [PATCH 4/5] dt-bindings: pps: pps-gpio: introduce pulse-width
 properties

On 25/06/2023 16:21, Eliav Farber wrote:
> Add two new optional properties to calculate PPS pulse-width in nano
> seconds:
>  - assert-pulse-width
>  - clear-pulse-width
> 
> Signed-off-by: Eliav Farber <farbere@...zon.com>
> ---
>  Documentation/devicetree/bindings/pps/pps-gpio.txt | 6 ++++++

No, no, one new property could sneak in, but three are a no go. DT schema.

>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt b/Documentation/devicetree/bindings/pps/pps-gpio.txt
> index 8d588e38c44e..9ecfd5fb3b63 100644
> --- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
> @@ -18,6 +18,12 @@ Optional properties:
>                   opposite of the assert edge (if assert is rising-edge then
>                   clear is falling-edge and if assert is falling-edge then
>                   clear is rising-edge).
> +- assert-pulse-width: when present, assert pulse width will be calculated in
> +                      nano seconds.
> +                      It should be enabled only if 'capture-clear' is enabled.
> +- clear-pulse-width: when present, clear pulse width will be calculated in
> +                     nano seconds.
> +                     It should be enabled only if 'capture-clear' is enabled.


I don't understand the description. Property name suggests there is some
units (so you need to use common property unit suffix), but description
suggests that you change the units to nanoseconds. That's very confusing.

Best regards,
Krzysztof