[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230625161553.11073-1-aarongt.shen@gmail.com>
Date: Mon, 26 Jun 2023 00:15:53 +0800
From: Guiting Shen <aarongt.shen@...il.com>
To: stern@...land.harvard.edu, gregkh@...uxfoundation.org,
nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
claudiu.beznea@...rochip.com
Cc: linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Guiting Shen <aarongt.shen@...il.com>
Subject: [PATCH v2] usb: ohci-at91: Fix the unhandle interrupt when resume
The ohci_hcd_at91_drv_suspend() sets ohci->rh_state to OHCI_RH_HALTED when
suspend which will let the ohci_irq() skip the interrupt after resume. And
nobody to handle this interrupt.
According to the comment in ohci_hcd_at91_drv_suspend(), it need to reset
when resume from suspend(MEM) to fix.
Signed-off-by: Guiting Shen <aarongt.shen@...il.com>
---
drivers/usb/host/ohci-at91.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index b9ce8d80f20b..1a0356d9ea15 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -672,7 +672,12 @@ ohci_hcd_at91_drv_resume(struct device *dev)
else
at91_start_clock(ohci_at91);
- ohci_resume(hcd, false);
+ /*
+ * need to reset according to the comment of suspend routine,
+ * otherwise the ohci_irq would skip the interrupt if ohci_state
+ * was OHCI_RH_HALTED.
+ */
+ ohci_resume(hcd, !ohci_at91->wakeup);
return 0;
}
--
2.25.1
Powered by blists - more mailing lists