linux-kernel - Re: [PATCH v2] elf: correct note name comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875y7c5hgd.fsf@tarshish>
Date:   Sun, 25 Jun 2023 06:44:09 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     Kees Cook <keescook@...omium.org>
Cc:     Eric Biederman <ebiederm@...ssion.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] elf: correct note name comment

Hi Kees,

On Fri, Jun 23 2023, Kees Cook wrote:
> On Fri, Jun 23, 2023 at 08:50:11AM +0300, Baruch Siach wrote:
>> NT_PRFPREG note is named "CORE". Correct the comment accordingly.
>> 
>> Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support")
>> Signed-off-by: Baruch Siach <baruch@...s.co.il>
>> ---
>> 
>> v2: Swap "CORE" and "LINUX" as noted by Kees
>> ---
>>  include/uapi/linux/elf.h | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h
>> index ac3da855fb19..4d1c8d46e7f0 100644
>> --- include/uapi/linux/elf.h
>> +++ include/uapi/linux/elf.h
>
> Hi, I took this patch, but it seems something is misconfigured on your
> end for patch generation -- normally I'd expect to need "-p1", not "-p0"
> to apply patches. Are you using "git format-patch" to produce these
> patches?

I recently enabled diff.noprefix for easier copying of file names from
git-diff output. I have now noticed the git-format-patch is also
affected, and that it breaks the default git-am -p1. So I have reverted
diff.noprefix to its default.

Sorry for the inconvenience, and thanks for letting me know.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -