linux-kernel - Re: [net-next Patch 1/3] octeontx2-pf: implement transmit schedular allocation algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR18MB447437B8E24747DECA9B2949DE21A@PH0PR18MB4474.namprd18.prod.outlook.com>
Date:   Sun, 25 Jun 2023 04:19:24 +0000
From:   Hariprasad Kelam <hkelam@...vell.com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Naveen Mamindlapalli <naveenm@...vell.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "maxtram95@...il.com" <maxtram95@...il.com>,
        "corbet@....net" <corbet@....net>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [net-next Patch 1/3] octeontx2-pf: implement transmit schedular
 allocation algorithm



> On Thu, 2023-06-22 at 14:26 +0530, Hariprasad Kelam wrote:
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> > b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> > index 19773284be27..0c5d2f79dc15 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> > @@ -35,6 +35,7 @@ struct otx2_qos_cfg {
> >  	int dwrr_node_pos[NIX_TXSCH_LVL_CNT];
> >  	u16
> schq_contig_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
> >  	u16 schq_list[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
> > +	u16
> schq_used_index[NIX_TXSCH_LVL_CNT][MAX_TXSCHQ_PER_FUNC];
> 
> This struct is already quite big, and you use schq_used_index[x][y] as a bool.
> I think you will be better off changing the used type accordingly.
> 
> Side note 'schq_index_used' sounds a little more clear to me, but could be
> simply ENONATIVELANG here ;)

Thanks for the reply,  will address the changes in the next version.

Thanks,
Hariprasad k
> 
> Cheers,
> 
> Paolo