linux-kernel - Re: Fwd: After kernel 6.3.7 or 6.3.8 b43 driver fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67faf4f4-f36c-3ff7-03b8-cd259e4a5548@lwfinger.net>
Date:   Sun, 25 Jun 2023 18:05:30 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Sardonimous <sardonimous@...mail.com>,
        Arnd Bergmann <arnd@...db.de>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Regressions <regressions@...ts.linux.dev>,
        Linux Wireless <linux-wireless@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>
Cc:     Michael Büsch <m@...s.ch>,
        kernel test robot <lkp@...el.com>,
        Simon Horman <simon.horman@...igine.com>,
        Kalle Valo <kvalo@...nel.org>
Subject: Re: Fwd: After kernel 6.3.7 or 6.3.8 b43 driver fails

On 6/25/23 16:11, Sardonimous wrote:
> On 6/25/23 13:17, Larry Finger wrote:
> 
>> On 6/25/23 13:12, Arnd Bergmann wrote:
>>> On Sun, Jun 25, 2023, at 18:58, Sardonimous wrote:
>>>> I have been unable to get DMA to work in the past.  So I have been
>>>> configuring it with PIO=1 (/etc/modprobe,d/b43.conf):
>>>>
>>>>       options b43 pio=1 qos=0
>>>>
>>>
>>> I think the qos=0 parameter is what causes the WARN_ON(), as that
>>> causes the use of only one queue, while the warning happens when
>>> tx function iterates over all the queues and warns that they don't
>>> exist.
>>
>> I agree and suggest running with no options. If we need debug, we can turn it 
>> on later.
>>
>> Larry
> 
> Sure. Of course, this is what I started out with years ago (2017?) when I was 
> trying to get this to work.
> 
> Now:
> Linux version 6.3.9-arch1-1 (linux@...hlinux) (gcc (GCC) 13.1.1 20230429, GNU ld 
> (GNU Binutils) 2.40.0) #1 SMP PREEMPT_DYNAMIC Wed, 21 Jun 2023 20:46:20 +0000
> 
> This is the sort of loop I get (dmesg | grep b43):
> 
> [   31.979539] b43-pci-bridge 0000:02:00.0: Sonics Silicon Backplane found on 
> PCI device 0000:02:00.0
> [   35.239389] b43-phy0: Broadcom 4322 WLAN found (core revision 16)
> [   35.275018] b43-phy0: Found PHY: Analog 8, Type 4 (N), Revision 4
> [   35.275046] b43-phy0: Found Radio: Manuf 0x17F, ID 0x2056, Revision 3, Version 0
> [   66.890631] b43-phy0: Loading firmware version 784.2 (2012-08-15 21:35:19)
> [   67.437162] b43-phy0 ERROR: DMA RX reset timed out
> [   67.498976] b43 ssb0:0: Timeout waiting for bitmask 01800000 on register 0F90 
> to clear
> [   67.707177] b43-phy0: Loading firmware version 784.2 (2012-08-15 21:35:19)
> [  391.127300] b43-phy0 ERROR: DMA RX reset timed out
> [  391.360514] b43-phy0 ERROR: DMA TX reset timed out
> [  391.382127] b43 ssb0:0: Timeout waiting for bitmask 01800000 on register 0F90 
> to clear
> [  391.590659] b43-phy0: Loading firmware version 784.2 (2012-08-15 21:35:19)
> [  709.123840] b43-phy0 ERROR: DMA RX reset timed out
> [  709.357235] b43-phy0 ERROR: DMA TX reset timed out
> [  709.378623] b43 ssb0:0: Timeout waiting for bitmask 01800000 on register 0F90 
> to clear
> [  709.573851] b43-phy0: Loading firmware version 784.2 (2012-08-15 21:35:19)

Sardonimous,

Did it ever work with DMA. or was PIO the only way to get it to work?

If you add in only the pio=1 option without qos, will it work?

If I were to send you some test patches, could you create a kernel with them 
applied?

Larry