linux-kernel - Re: [PATCH v4] arm64: dts: ti: k3-j721s2: Add support for CAN instances 3 and 5 in main domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0070e00a-89c0-9b2b-8753-e1835b5aad15@ti.com>
Date:   Sun, 25 Jun 2023 10:27:13 +0530
From:   "Kumar, Udit" <u-kumar1@...com>
To:     Bhavya Kapoor <b-kapoor@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <nm@...com>, <vigneshr@...com>, <kristo@...nel.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH v4] arm64: dts: ti: k3-j721s2: Add support for CAN
 instances 3 and 5 in main domain

Hi Bhavya

On 6/23/2023 12:21 AM, Bhavya Kapoor wrote:
> CAN instances 3 and 5 in the main domain are brought on the common
> processor board through header J27 and J28. The CAN High and Low lines
> from the SoC are routed through a mux on the SoM. The select lines need
> to be set for the CAN signals to get connected to the transceivers on
> the common processor board. Threfore, add respective mux, transceiver
> dt nodes to add support for these CAN instances.
> [...]
>   
> +	mux0: mux-controller@0 {
> +		compatible = "gpio-mux";
> +		#mux-state-cells = <1>;
> +		mux-gpios = <&exp_som 1 GPIO_ACTIVE_HIGH>;
> +	};
> +


You will get more warning with @0 and @1

   DTC_CHK arch/arm64/boot/dts/ti//k3-j721s2-common-proc-board.dtb
/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: /: 
mux-controller@0: 'anyOf' conditional failed, one must be fixed:
         'reg' is a required property
         'ranges' is a required property
         From schema: 
/home/udit/.local/lib/python3.10/site-packages/dtschema/schemas/root-node.yaml
/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: /: 
mux-controller@1: 'anyOf' conditional failed, one must be fixed:
         'reg' is a required property
         'ranges' is a required property

> +	mux1: mux-controller@1 {
> +		compatible = "gpio-mux";
> +		#mux-state-cells = <1>;
> +		mux-gpios = <&exp_som 2 GPIO_ACTIVE_HIGH>;
> +	};
> +
>   	transceiver0: can-phy0 {
>   		/* standby pin has been grounded by default */
>   		compatible = "ti,tcan1042";