linux-kernel - Re: [PATCH] md/raid1: prioritize adding disk to 'removed' mirror

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06f8c00f-d6a3-f93b-0db7-b89a3f49d91e@huaweicloud.com>
Date:   Sun, 25 Jun 2023 14:46:42 +0800
From:   Li Nan <linan666@...weicloud.com>
To:     Yu Kuai <yukuai1@...weicloud.com>, song@...nel.org
Cc:     linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
        linan122@...wei.com, yi.zhang@...wei.com, houtao1@...wei.com,
        yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH] md/raid1: prioritize adding disk to 'removed' mirror



在 2023/6/25 10:06, Yu Kuai 写道:
> Hi,
> 
> 在 2023/06/24 1:25, linan666@...weicloud.com 写道:
>> From: Li Nan <linan122@...wei.com>
>>
>> New disk should be added to "removed" position first instead of to be a
>> replacement. Commit 6090368abcb4 ("md/raid10: prioritize adding disk to
>> 'removed' mirror") has fixed this issue for raid10. This patch fixes 
>> raid1.
> 
> This commit message "This patch ..." shound use imperative mood, other
> than that, this patch LGTM.
> 
> Reviewed-by: Yu Kuai <yukuai3@...wei.com>

OK, I will change it. Thanks for your review.

-- 
Thanks,
Nan