linux-kernel - Re: [PATCH] zonefs: do not use append if device does not support it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jun 2023 17:54:20 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     Andreas Hindborg <nmi@...aspace.dk>,
        Damien Le Moal <dlemoal@...nel.org>
CC:     "open list:ZONEFS FILESYSTEM" <linux-fsdevel@...r.kernel.org>,
        "gost.dev@...sung.com" <gost.dev@...sung.com>,
        Andreas Hindborg <a.hindborg@...sung.com>,
        Naohiro Aota <Naohiro.Aota@....com>,
        Johannes Thumshirn <jth@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] zonefs: do not use append if device does not support it

On 26.06.23 18:47, Andreas Hindborg wrote:
> From: "Andreas Hindborg (Samsung)" <nmi@...aspace.dk>
> 
> Zonefs will try to use `zonefs_file_dio_append()` for direct sync writes even if
> device `max_zone_append_sectors` is zero. This will cause the IO to fail as the
> io vector is truncated to zero. It also causes a call to
> `invalidate_inode_pages2_range()` with end set to UINT_MAX, which is probably
> not intentional. Thus, do not use append when device does not support it.
> 

I'm sorry but I think it has been stated often enough that for Linux Zone Append
is a mandatory feature for a Zoned Block Device. Therefore this path is essentially
dead code as max_zone_append_sectors will always be greater than zero.

So this is a clear NAK from my side.