linux-kernel - Re: [PATCH 0/2] RISC-V: Probe for misaligned access speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs-Hsu681qusmGn+aWarnTXQ=e20C52jSZU-q-hWihP+7ud7Q@mail.gmail.com>
Date:   Mon, 26 Jun 2023 12:49:10 -0700
From:   Evan Green <evan@...osinc.com>
To:     David Laight <David.Laight@...lab.com>
Cc:     Yangyu Chen <cyy@...self.name>,
        "ajones@...tanamicro.com" <ajones@...tanamicro.com>,
        "alexghiti@...osinc.com" <alexghiti@...osinc.com>,
        "andy.chiu@...ive.com" <andy.chiu@...ive.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        "apatel@...tanamicro.com" <apatel@...tanamicro.com>,
        "conor.dooley@...rochip.com" <conor.dooley@...rochip.com>,
        "corbet@....net" <corbet@....net>,
        "greentime.hu@...ive.com" <greentime.hu@...ive.com>,
        "guoren@...nel.org" <guoren@...nel.org>,
        "heiko.stuebner@...ll.eu" <heiko.stuebner@...ll.eu>,
        "heiko@...ech.de" <heiko@...ech.de>,
        "jeeheng.sia@...rfivetech.com" <jeeheng.sia@...rfivetech.com>,
        "jszhang@...nel.org" <jszhang@...nel.org>,
        "leyfoon.tan@...rfivetech.com" <leyfoon.tan@...rfivetech.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "lizhengyu3@...wei.com" <lizhengyu3@...wei.com>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "palmer@...osinc.com" <palmer@...osinc.com>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "samuel@...lland.org" <samuel@...lland.org>,
        "shosie@...osinc.com" <shosie@...osinc.com>,
        "sunilvl@...tanamicro.com" <sunilvl@...tanamicro.com>,
        "xianting.tian@...ux.alibaba.com" <xianting.tian@...ux.alibaba.com>
Subject: Re: [PATCH 0/2] RISC-V: Probe for misaligned access speed

On Mon, Jun 26, 2023 at 2:24 AM David Laight <David.Laight@...lab.com> wrote:
>
> From: Yangyu Chen
> > Sent: 24 June 2023 11:22
> >
> > Hi,
> >
> > Thanks for doing this.
> >
> > On 6/24/23 6:20 AM, Evan Green wrote:
> > > I don't have a machine where misaligned accesses are slow, but I'd be
> > > interested to see the results of booting this series if someone did.
> >
> > I have tested your patches on a 100MHz BigCore rocket-chip with opensbi running on FPGA with
> > 72bit(64bit+ECC) DDR3 1600MHz memory. As the rocket-chip did not support misaligned memory access,
> > every misaligned memory access will trap and emulated by SBI.
> >
> > Here is the result:
> ...
> > ~ # dmesg | grep Unaligned
> > [    0.210140] cpu1: Unaligned word copy 0 MB/s, byte copy 38 MB/s, misaligned accesses are slow
> > [    0.410715] cpu0: Unaligned word copy 0 MB/s, byte copy 35 MB/s, misaligned accesses are slow
>
> How many misaligned cycles are in the test loop?
> If emulated ones are that slow you pretty much only need to test one.

The code does as many cycles as it can in a fixed number of jiffies.

>
> Also it is pretty clear that you really don't want to be emulating them.
> If the emulation is hidden from the kernel that really doesn't help at all.

>From what I understand there's work being done to give the kernel some
awareness and even control over the misaligned access
trapping/emulation. It won't help today's systems though, and either
way you're right emulating is very very slow.
-Evan