linux-kernel - Re: [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jun 2023 22:17:16 +0200
From:   Luca Weiss <luca@...tu.xyz>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Sibi Sankar <quic_sibis@...cinc.com>,
        Luca Weiss <luca.weiss@...rphone.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        AngeloGioacchino Del Regno <kholk11@...il.com>,
        Vinod Koul <vkoul@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-remoteproc@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>
Subject: Re: [PATCH 3/7] arm64: dts: qcom: pm6150l: Add missing short interrupt

On Montag, 26. Juni 2023 22:00:25 CEST Konrad Dybcio wrote:
> Add the missing short interrupt. This fixes the schema warning:
> 
> wled@...0: interrupt-names: ['ovp'] is too short
> 
> Fixes: fe508ced49dd ("arm64: dts: qcom: pm6150l: Add wled node")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>  arch/arm64/boot/dts/qcom/pm6150l.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> b/arch/arm64/boot/dts/qcom/pm6150l.dtsi index 6a7fe1e59f15..d13a1ab7c20b
> 100644
> --- a/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm6150l.dtsi
> @@ -121,8 +121,9 @@ pm6150l_flash: led-controller@...0 {
>  		pm6150l_wled: leds@...0 {
>  			compatible = "qcom,pm6150l-wled";
>  			reg = <0xd800>, <0xd900>;
> -			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
> -			interrupt-names = "ovp";
> +			interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
> +				     <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
> +			interrupt-names = "ovp", "short";

Are you sure this interrupt really exists? It's not a thing used downstream at
least:
https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/pm6150l.dtsi#293

Regards
Luca

>  			label = "backlight";
> 
>  			status = "disabled";