linux-kernel - Re: [PATCH net-next] libceph: Partially revert changes to support MSG_SPLICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3109248.1687812255@warthog.procyon.org.uk>
Date:   Mon, 26 Jun 2023 21:44:15 +0100
From:   David Howells <dhowells@...hat.com>
To:     Ilya Dryomov <idryomov@...il.com>
Cc:     dhowells@...hat.com, netdev@...r.kernel.org,
        Xiubo Li <xiubli@...hat.com>, Jeff Layton <jlayton@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Jens Axboe <axboe@...nel.dk>,
        Matthew Wilcox <willy@...radead.org>,
        ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] libceph: Partially revert changes to support MSG_SPLICE_PAGES

Ilya Dryomov <idryomov@...il.com> wrote:

>   if (sendpage_ok(bv.bv_page))
>           msg.msg_flags |= MSG_SPLICE_PAGES;
>   else
>           msg.msg_flags &= ~MSG_SPLICE_PAGES;

Hmmm...  I'm not sure there's any guarantee that msg, including msg_flags,
won't get altered by ->sendmsg().

David