linux-kernel - Re: [PATCH] counter: Fix menuconfig "Counter support" submenu entries disappearance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZJoO++gEMiDsZioz@fedora>
Date:   Mon, 26 Jun 2023 18:19:39 -0400
From:   William Breathitt Gray <william.gray@...aro.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-iio@...r.kernel.org,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        andy.shevchenko@...il.com
Subject: Re: [PATCH] counter: Fix menuconfig "Counter support" submenu
 entries disappearance

On Sun, Jun 25, 2023 at 12:11:08PM +0100, Jonathan Cameron wrote:
> On Tue, 20 Jun 2023 17:12:13 -0400
> William Breathitt Gray <william.gray@...aro.org> wrote:
> 
> > On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote:
> > > Hi,
> > > 
> > > On 6/20/23 10:01, William Breathitt Gray wrote:  
> > > > The current placement of the I8254 Kconfig entry results in the
> > > > disappearance of the "Counter support" submenu items in menuconfig. Move
> > > > the I8254 above the menuconfig COUNTER entry to restore the intended
> > > > submenu behavior.
> > > > 
> > > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
> > > > Reported-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
> > > > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
> > > > Signed-off-by: William Breathitt Gray <william.gray@...aro.org>  
> > > 
> > > Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
> > > 
> > > but why is I8254 here at all? Users cannot enable it
> > > and nothing selects it.  Is it a WIP?
> > > 
> > > Thanks.  
> > 
> > There are pending patches for two drivers to use it: 104-dio-48e[^1] and
> > stx104[^2]. Those will be picked up in their respective subsystem trees
> > (by Bart and Jonathan I presume).
> > 
> 
> I missed the IIO patch in that series. Could you resend please.
> 
> Jonathan
> 
> > William Breathitt Gray
> > 
> > [^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@linaro.org/
> > [^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@linaro.org/

I8254 is expected to land in 6.5 so I'll wait and resend the IIO patch
rebased on 6.5-rc1 once it's released in a couple weeks. That'll make
things simple for you and avoid the need for an immutable branch.

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)