linux-kernel - Re: [PATCH 5.4 3/5] cifs: Introduce helpers for finding TCP connection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANT5p=pB9chz2CrWK0Znz-wp6-znFWJnCz6jHeCuUTt6GqUv-Q@mail.gmail.com>
Date:   Mon, 26 Jun 2023 12:00:44 +0530
From:   Shyam Prasad N <nspmangalore@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Rishabh Bhatnagar <risbhat@...zon.com>, pc@....nz,
        stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-cifs@...r.kernel.org, Aurelien Aptel <aaptel@...e.com>,
        Steve French <stfrench@...rosoft.com>
Subject: Re: [PATCH 5.4 3/5] cifs: Introduce helpers for finding TCP connection

On Mon, Jun 26, 2023 at 11:43 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Mon, Jun 26, 2023 at 11:34:44AM +0530, Shyam Prasad N wrote:
> > On Sat, Jun 24, 2023 at 3:14 AM Rishabh Bhatnagar <risbhat@...zon.com> wrote:
> > >
> > > From: "Paulo Alcantara (SUSE)" <pc@....nz>
> > >
> > > commit 345c1a4a9e09dc5842b7bbb6728a77910db69c52 upstream.
> > >
> > > Add helpers for finding TCP connections that are good candidates for
> > > being used by DFS refresh worker.
> > >
> > > Signed-off-by: Paulo Alcantara (SUSE) <pc@....nz>
> > > Reviewed-by: Aurelien Aptel <aaptel@...e.com>
> > > Signed-off-by: Steve French <stfrench@...rosoft.com>
> > > Signed-off-by: Rishabh Bhatnagar <risbhat@...zon.com>
> > > ---
> > >  fs/cifs/dfs_cache.c | 44 +++++++++++++++++++++++++++++++-------------
> > >  1 file changed, 31 insertions(+), 13 deletions(-)
> > >
> > > diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
> > > index 3ca65051b55c..31b3dc09e109 100644
> > > --- a/fs/cifs/dfs_cache.c
> > > +++ b/fs/cifs/dfs_cache.c
> > > @@ -1305,6 +1305,30 @@ static char *get_dfs_root(const char *path)
> > >         return npath;
> > >  }
> > >
> > > +static inline void put_tcp_server(struct TCP_Server_Info *server)
> > > +{
> > > +       cifs_put_tcp_session(server, 0);
> > > +}
> > > +
> > > +static struct TCP_Server_Info *get_tcp_server(struct smb_vol *vol)
> > > +{
> > > +       struct TCP_Server_Info *server;
> > > +
> > > +       server = cifs_find_tcp_session(vol);
> > > +       if (IS_ERR_OR_NULL(server))
> > > +               return NULL;
> > > +
> > > +       spin_lock(&GlobalMid_Lock);
> > > +       if (server->tcpStatus != CifsGood) {
> > > +               spin_unlock(&GlobalMid_Lock);
> > > +               put_tcp_server(server);
> > > +               return NULL;
> > > +       }
> > > +       spin_unlock(&GlobalMid_Lock);
> >
> > We've moved away from using GlobalMid_Lock for anything other than MIDs.
> > Please use server->srv_lock instead.
>
> This is just a backport of a commit that showed up in the 5.6 release.
> It's not new development.
>
> thanks,
>
> greg k-h

Ah. I get it now.
Sorry for the confusion.

-- 
Regards,
Shyam