linux-kernel - Re: [PATCH v2] cdx: add MSI support for CDX bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d866dba9-3b0f-3573-9baf-0d02f4049fcb@amd.com>
Date:   Mon, 26 Jun 2023 13:23:27 +0530
From:   Nipun Gupta <nipun.gupta@....com>
To:     gregkh@...uxfoundation.org, maz@...nel.org, tglx@...utronix.de,
        jgg@...pe.ca, linux-kernel@...r.kernel.org
Cc:     git@....com, harpreet.anand@....com,
        pieter.jansen-van-vuuren@....com, nikhil.agarwal@....com,
        michal.simek@....com, abhijit.gangurde@....com
Subject: Re: [PATCH v2] cdx: add MSI support for CDX bus



On 6/6/2023 4:32 PM, Nipun Gupta wrote:
> 
> 
> On 5/18/2023 5:14 PM, Nipun Gupta wrote:
>> Add CDX-MSI domain per CDX controller with gic-its domain as
>> a parent, to support MSI for CDX devices. CDX devices allocate
>> MSIs from the CDX domain. Also, introduce APIs to alloc and free
>> IRQs for CDX domain.
>>
>> In CDX subsystem firmware is a controller for all devices and
>> their configuration. CDX bus controller sends all the write_msi_msg
>> commands to firmware running on RPU and the firmware interfaces with
>> actual devices to pass this information to devices
>>
>> Since, CDX controller is the only way to communicate with the Firmware
>> for MSI write info, CDX domain per controller required in contrast to
>> having a CDX domain per device.
>>
>> Co-developed-by: Nikhil Agarwal <nikhil.agarwal@....com>
>> Signed-off-by: Nikhil Agarwal <nikhil.agarwal@....com>
>> Co-developed-by: Abhijit Gangurde <abhijit.gangurde@....com>
>> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@....com>
>> Signed-off-by: Nipun Gupta <nipun.gupta@....com>
>> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>
>> Tested-by: Nikhil Agarwal <nikhil.agarwal@....com>
>> ---
>>
>> Changes v1->v2:
>> - fixed scenario where msi write was called asyncronously in
>>    an atomic context, by using irq_chip_(un)lock, and using sync
>>    MCDI API for write MSI message.
>> - fixed broken Signed-off-by chain.
> 
> Hi Thomas,
> 
> Did you had a chance to look at patch v2. Please let me know in case 
> anything else is required to be updated.

Hi Thomas,

A gentle reminder, could you please have a look into this updated 
version of the patch?

Thanks,
Nipun