linux-kernel - Re: [PATCH v2] perf evsel amd: Fix IBS error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <01605914-60fc-9540-389b-7dc377990f1e@amd.com>
Date:   Mon, 26 Jun 2023 16:12:50 +0530
From:   Ravi Bangoria <ravi.bangoria@....com>
To:     acme@...nel.org
Cc:     peterz@...radead.org, irogers@...gle.com, jolsa@...nel.org,
        namhyung@...nel.org, adrian.hunter@...el.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        sandipan.das@....com, ananth.narayan@....com,
        santosh.shukla@....com, Ravi Bangoria <ravi.bangoria@....com>
Subject: Re: [PATCH v2] perf evsel amd: Fix IBS error message

On 26-Jun-23 4:09 PM, Ravi Bangoria wrote:
> AMD IBS can do per-process profiling[1] and is no longer restricted to
> per-cpu or systemwide only. Remove stale error message. Also, checking
> just exclude_kernel is not sufficient since IBS does not support any
> privilege filters. So include all exclude_* checks. And finally, move
> these checks under tools/perf/arch/x86/ from generic code.
> 
> Before:
>   $ sudo ./perf record -e ibs_op//k -C 0
>   Error:
>   AMD IBS may only be available in system-wide/per-cpu mode.  Try
>   using -a, or -C and workload affinity
> 
> After:
>   $ sudo ./perf record -e ibs_op//k -C 0
>   Error:
>   AMD IBS doesn't support privilege filtering. Try again with
>   exclude_{kernel|user|hv|idle|host|guest}=0.

[1] https://git.kernel.org/torvalds/c/30093056f7b2