linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8350: fix BAM DMA crash and reboot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jun 2023 12:52:44 +0200
From:   Thorsten Leemhuis <regressions@...mhuis.info>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: Re: [PATCH] arm64: dts: qcom: sm8350: fix BAM DMA crash and reboot

On 21.06.23 16:37, Krzysztof Kozlowski wrote:
> On 21/06/2023 16:36, Krzysztof Kozlowski wrote:
>> SM8350 HDK and MTP boards were silently dying and rebooting during BAM
>> DMA probe:
>>
>>   [    1.574304] vreg_bob: Setting 3008000-3960000uV
>>   [    1.576918] bam-dFormat: Log Type - Time(microsec) - Message -
>>   Optional Info
>>   Log Type: B - Since Boot(Power On Reset),  D - Delta,  S - Statistic
>>   S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1
>>   S - IMAGE_VARIANT_STRING=SocLahainaLAA
>>   S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77
>>   S - Boot Interface: UFS
>>
>> It seems that BAM DMA is locally controller (not by firmware) and
>> requires proper initialization by the driver prior to use, at least on
>> HDK8350 and MTP8350, but probably on all boards.
>>
>> Fixes: f1040a7fe8f0 ("arm64: dts: qcom: sm8350: Add Crypto Engine support")

BTW, did this make any progress? It's not yet in -next afaics; might be
nice to have this merged so it goes to Linus together with f1040a7fe8f0.

>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Many thx for fixing and involving regzbot. FWIW, this...

> #regzbot fix: f1040a7fe8f069d2259ab3dab9190210005ceb33

...didn't work, as you got things backwards: The fix command is used in
reply to a report to specify which commit fixes it. I'll take care of
fixing that (and also mediate about the docs, maybe this
misunderstanding can be avoided by improving things).

Side note: using a

 Link:
https://lore.kernel.org/lkml/d239ad07-fbdd-16fa-3555-5bcf33c67059@linaro.org/

(or Closes:) in the patch description would have been the ideal way for
regzbot here. Those Links are also what Linus wants to see so everyone
can when needed understand the backstory (now or in the future), which
is why regzbot relies on them.

Whatever, not all that important. Thx again for giving regzbot a try.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.