linux-kernel - Re: [PATCH] iio: adc: ad7192: Use sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Jun 2023 13:19:49 +0200
From:   Nuno Sá <noname.nuno@...il.com>
To:     Alisa Roman <alisa.roman@...log.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Alexandru Tachici <alexandru.tachici@...log.com>,
        Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7192: Use sysfs_emit_at

On Tue, 2023-06-20 at 19:31 +0300, Alisa Roman wrote:
> Replace scnprintf with sysfs_emit_at which is the preferred alternative.
> 
> Also make sure each fractional digit is in its place by padding with
> zeros up to 3 digits: "...%03d...".
> 
> Signed-off-by: Alisa Roman <alisa.roman@...log.com>
> ---

Reviewed-by: Nuno Sa <nuno.sa@...log.com>

>  drivers/iio/adc/ad7192.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> index e23d9a7dcc9e..c980bc871412 100644
> --- a/drivers/iio/adc/ad7192.c
> +++ b/drivers/iio/adc/ad7192.c
> @@ -561,9 +561,8 @@ static ssize_t ad7192_show_filter_avail(struct device *dev,
>         ad7192_get_available_filter_freq(st, freq_avail);
>  
>         for (i = 0; i < ARRAY_SIZE(freq_avail); i++)
> -               len += scnprintf(buf + len, PAGE_SIZE - len,
> -                                "%d.%d ", freq_avail[i] / 1000,
> -                                freq_avail[i] % 1000);
> +               len += sysfs_emit_at(buf, len, "%d.%03d ", freq_avail[i] / 1000,
> +                                    freq_avail[i] % 1000);
>  
>         buf[len - 1] = '\n';
>