linux-kernel - Re: [PATCH v2 3/4] drm/ttm: Don't leak a resource on eviction error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJl1dvx311ixwQ3I@ashyti-mobl2.lan>
Date:   Mon, 26 Jun 2023 13:24:38 +0200
From:   Andi Shyti <andi.shyti@...ux.intel.com>
To:     Thomas Hellström 
        <thomas.hellstrom@...ux.intel.com>
Cc:     intel-xe@...ts.freedesktop.org,
        Andrey Grodzovsky <andrey.grodzovsky@....com>,
        Christian König <christian.koenig@....com>,
        Huang Rui <ray.huang@....com>, dri-devel@...ts.freedesktop.org,
        stable@...r.kernel.org, Nirmoy Das <nirmoy.das@...el.com>,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Christian König 
        <ckoenig.leichtzumerken@...il.com>,
        Andi Shyti <andi.shyti@...ux.intel.com>
Subject: Re: [PATCH v2 3/4] drm/ttm: Don't leak a resource on eviction error

Hi Thomas,

On Mon, Jun 26, 2023 at 11:14:49AM +0200, Thomas Hellström wrote:
> On eviction errors other than -EMULTIHOP we were leaking a resource.
> Fix.
> 
> v2:
> - Avoid yet another goto (Andi Shyti)
> 
> Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.")
> Cc: Andrey Grodzovsky <andrey.grodzovsky@....com>
> Cc: Christian König <christian.koenig@....com>
> Cc: Christian Koenig <christian.koenig@....com>
> Cc: Huang Rui <ray.huang@....com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: <stable@...r.kernel.org> # v5.15+
> Signed-off-by: Thomas Hellström <thomas.hellstrom@...ux.intel.com>
> Reviewed-by: Nirmoy Das <nirmoy.das@...el.com> #v1

Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com> 

Andi