linux-kernel - Re: [PATCH v2 4/4] drm/ttm: Don't leak a resource on swapout move error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f63137cd-2032-1598-a1d7-484248ef1d02@gmail.com>
Date:   Mon, 26 Jun 2023 13:33:45 +0200
From:   Christian König <ckoenig.leichtzumerken@...il.com>
To:     Thomas Hellström 
        <thomas.hellstrom@...ux.intel.com>, intel-xe@...ts.freedesktop.org
Cc:     Christian König <christian.koenig@....com>,
        dri-devel@...ts.freedesktop.org, stable@...r.kernel.org,
        Nirmoy Das <nirmoy.das@...el.com>,
        Andi Shyti <andi.shyti@...ux.intel.com>,
        intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] drm/ttm: Don't leak a resource on swapout move
 error

Am 26.06.23 um 11:14 schrieb Thomas Hellström:
> If moving the bo to system for swapout failed, we were leaking
> a resource. Fix.
>
> Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2")
> Cc: Christian König <christian.koenig@....com>
> Cc: "Christian König" <ckoenig.leichtzumerken@...il.com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: <stable@...r.kernel.org> # v5.14+
> Signed-off-by: Thomas Hellström <thomas.hellstrom@...ux.intel.com>
> Reviewed-by: Nirmoy Das <nirmoy.das@...el.com>
> Reviewed-by: Andi Shyti <andi.shyti@...ux.intel.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index c0e3bbd21d3d..d9a8f227f310 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1166,6 +1166,7 @@ int ttm_bo_swapout(struct ttm_buffer_object *bo, struct ttm_operation_ctx *ctx,
>   		ret = ttm_bo_handle_move_mem(bo, evict_mem, true, ctx, &hop);
>   		if (unlikely(ret != 0)) {
>   			WARN(ret == -EMULTIHOP, "Unexpected multihop in swaput - likely driver bug.\n");
> +			ttm_resource_free(bo, &evict_mem);
>   			goto out;
>   		}
>   	}