linux-kernel - Re: [PATCH v3 3/4] clk: sunxi-ng: Convert early providers to platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xedly2z3m.fsf@mansr.com>
Date:   Mon, 26 Jun 2023 13:21:33 +0100
From:   Måns Rullgård <mans@...sr.com>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        linux-sunxi@...ts.linux.dev,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] clk: sunxi-ng: Convert early providers to
 platform drivers

Samuel Holland <samuel@...lland.org> writes:

> The PRCM CCU drivers depend on clocks provided by other CCU drivers. For
> example, the sun8i-r-ccu driver uses the "pll-periph" clock provided by
> the SoC's main CCU.
>
> However, sun8i-r-ccu is an early OF clock provider, and many of the
> main CCUs (e.g. sun50i-a64-ccu) use platform drivers. This means that
> the consumer clocks will be orphaned until the supplier driver is bound.
> This can be avoided by converting the remaining CCUs to use platform
> drivers. Then fw_devlink will ensure the drivers are bound in the
> optimal order.
>
> The sun5i CCU is the only one which actually needs to be an early clock
> provider, because it provides the clock for the system timer. That one
> is left alone.
>
> Signed-off-by: Samuel Holland <samuel@...lland.org>
> ---
>
> (no changes since v1)
>
>  drivers/clk/sunxi-ng/Kconfig             | 20 ++++----
>  drivers/clk/sunxi-ng/ccu-sun4i-a10.c     | 58 +++++++++++++--------
>  drivers/clk/sunxi-ng/ccu-sun50i-h6-r.c   | 56 ++++++++++++--------
>  drivers/clk/sunxi-ng/ccu-sun50i-h616.c   | 33 ++++++++----
>  drivers/clk/sunxi-ng/ccu-sun6i-a31.c     | 40 +++++++++++----
>  drivers/clk/sunxi-ng/ccu-sun8i-a23.c     | 35 +++++++++----
>  drivers/clk/sunxi-ng/ccu-sun8i-a33.c     | 40 +++++++++++----
>  drivers/clk/sunxi-ng/ccu-sun8i-h3.c      | 62 ++++++++++++++--------
>  drivers/clk/sunxi-ng/ccu-sun8i-r.c       | 65 ++++++++++++++----------
>  drivers/clk/sunxi-ng/ccu-sun8i-v3s.c     | 57 +++++++++++++--------
>  drivers/clk/sunxi-ng/ccu-suniv-f1c100s.c | 38 ++++++++++----
>  11 files changed, 332 insertions(+), 172 deletions(-)

This broke the hstimer clocksource on A20 since it requires a clock
provided by the sun4i ccu driver.

-- 
Måns Rullgård