linux-kernel - Re: [PATCH] wifi: ray_cs: Remove invalid conditional statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGRGNgW_eeM2h7JBe98asaYjnF8hwAr50n8dfSabeK2H0u4=Qg@mail.gmail.com>
Date:   Mon, 26 Jun 2023 23:06:49 +1000
From:   Julian Calaby <julian.calaby@...il.com>
To:     You Kangren <youkangren@...o.com>
Cc:     Kalle Valo <kvalo@...nel.org>, Dongliang Mu <dzm91@...t.edu.cn>,
        Simon Horman <simon.horman@...igine.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "open list:RAYLINK/WEBGEAR 802.11 WIRELESS LAN DRIVER" 
        <linux-wireless@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com
Subject: Re: [PATCH] wifi: ray_cs: Remove invalid conditional statements

Hi,

On Mon, Jun 26, 2023 at 8:36 PM You Kangren <youkangren@...o.com> wrote:
>
> Remove invalid conditional statements to make the code clean
>
> Signed-off-by: You Kangren <youkangren@...o.com>

"to make the code clean" isn't enough to explain why this change might
be wanted. Are both branches the same? Is there a compiler warning?
How did you find this? etc.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/