linux-kernel - Re: [PATCH v2] rust: alloc: Add realloc and alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6a3bb29-ea6f-cdec-3f0f-4db51f385ec8@gmail.com>
Date:   Mon, 26 Jun 2023 10:11:40 -0300
From:   Martin Rodriguez Reboredo <yakoyoku@...il.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Boqun Feng <boqun.feng@...il.com>, rust-for-linux@...r.kernel.org,
        linux-kernel@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
        Alex Gaynor <alex.gaynor@...il.com>,
        Wedson Almeida Filho <wedsonaf@...il.com>,
        Gary Guo <gary@...yguo.net>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Benno Lossin <benno.lossin@...ton.me>
Subject: Re: [PATCH v2] rust: alloc: Add realloc and alloc_zeroed to the
 GlobalAlloc impl

On 6/26/23 06:40, Miguel Ojeda wrote:
> On Mon, Jun 26, 2023 at 5:34 AM Martin Rodriguez Reboredo
> <yakoyoku@...il.com> wrote:
>>
>> I think that this should go above Link and Signed-off-bys, although I'm
>> not sure if maintainers do it when is merged.
> 
> Both styles are used, it is fine either way. Personally, I pick one or
> the other depending on the kind of comment.
> 
> Having said that, there seems to be a missing `From:`, but I can fix
> that on my side if Björn is the intended author.
> 
>> Newbie question, aren't tabs in the commit message verboten?
> 
> I am not aware of such a rule, and there are commits in the kernel
> with tabs, e.g. commit 9828ed3f695a ("module: error out early on
> concurrent load of the same module file").
> 
> In any case, that text doesn't go into the commit message, because it
> is after the `---` line.
> 
> Cheers,
> Miguel

Alrighty, both make sense to me, thanks for the explanations!

-> Martin