linux-kernel - Re: [PATCH] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c3bcc62-28ba-e88f-6a19-4f620489284a@linaro.org>
Date:   Mon, 26 Jun 2023 15:38:27 +0200
From:   neil.armstrong@...aro.org
To:     Cong Yang <yangcong5@...qin.corp-partner.google.com>,
        sam@...nborg.org, daniel@...ll.ch, airlied@...il.com,
        dianders@...gle.com, hsinyi@...gle.com
Cc:     dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP

Hi,

On 26/06/2023 14:07, Cong Yang wrote:
> Because the setting of hproch is too small, there will be warning in
> kernel log[1]. After fine tune the HFP and HBP, this warning can be
> solved. The actual measurement frame rate is 60.1Hz.
> 
> [1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz
> 
> Signed-off-by: Cong Yang <yangcong5@...qin.corp-partner.google.com>
> ---
>   drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 3cc9fb0d4f5d..dc276c346fd1 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -2139,9 +2139,9 @@ static const struct panel_desc starry_himax83102_j02_desc = {
>   static const struct drm_display_mode starry_ili9882t_default_mode = {
>   	.clock = 165280,
>   	.hdisplay = 1200,
> -	.hsync_start = 1200 + 32,
> -	.hsync_end = 1200 + 32 + 30,
> -	.htotal = 1200 + 32 + 30 + 32,
> +	.hsync_start = 1200 + 72,
> +	.hsync_end = 1200 + 72 + 30,
> +	.htotal = 1200 + 72 + 30 + 72,
>   	.vdisplay = 1920,
>   	.vsync_start = 1920 + 68,
>   	.vsync_end = 1920 + 68 + 2,

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>

but can you resend with a appropriate Fixes tag ?

thanks,
Neil