linux-kernel - Re: [PATCH v2] usb: ohci-at91: Fix the unhandle interrupt when resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f33966d-3bc5-4ca3-bb6c-6e1d838c57f7@rowland.harvard.edu>
Date:   Mon, 26 Jun 2023 10:16:44 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Guiting Shen <aarongt.shen@...il.com>
Cc:     gregkh@...uxfoundation.org, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, claudiu.beznea@...rochip.com,
        linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: ohci-at91: Fix the unhandle interrupt when resume

On Mon, Jun 26, 2023 at 10:28:26AM +0800, Guiting Shen wrote:
> On Mon, Jun 26, 2023 at 04:04:29AM GMT+8, Alan Stern wrote:
> > This comment doesn't say why the code uses !ohci_at91->wakeup.  It 
> > should explain that.  For example:
> > 
> > 	/*
> > 	 * According to the comment in ohci_hcd_at91_drv_suspend()
> > 	 * we need to do a reset if the 48-MHz clock was stopped,
> > 	 * that is, if ohci_at91->wakeup is clear.  Tell ohci_resume()
> > 	 * to reset in this case by setting its "hibernated" flag.
> > 	 */
> > 
> 
> Ok, Thank you!
> Do I send the v3 patch after the merge window close?

You can send the patch at any time.  It doesn't matter whether the merge 
window is open or closed.

Alan Stern