linux-kernel - Re: [PATCH v2] HID: wacom: Use ktime_t rather than int when dealing with timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168779116662.356699.3703314952636539084.b4-ty@kernel.org>
Date:   Mon, 26 Jun 2023 16:54:21 +0200
From:   bentiss@...nel.org
To:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>,
        Jason Gerecke <killertofu@...il.com>
Cc:     Benjamin Tissoires <bentiss@...nel.org>,
        Ping Cheng <pinglinux@...il.com>,
        Aaron Armstrong Skomra <skomra@...il.com>,
        Joshua Dickens <Joshua@...hua-Dickens.com>,
        Peter Hutterer <peter.hutterer@...-t.net>,
        Jason Gerecke <jason.gerecke@...om.com>, stable@...r.kernel.org
Subject: Re: [PATCH v2] HID: wacom: Use ktime_t rather than int when dealing with timestamps

From: Benjamin Tissoires <bentiss@...nel.org>

On Thu, 08 Jun 2023 14:38:28 -0700, Jason Gerecke wrote:
> Code which interacts with timestamps needs to use the ktime_t type
> returned by functions like ktime_get. The int type does not offer
> enough space to store these values, and attempting to use it is a
> recipe for problems. In this particular case, overflows would occur
> when calculating/storing timestamps leading to incorrect values being
> reported to userspace. In some cases these bad timestamps cause input
> handling in userspace to appear hung.
> 
> [...]

Updated the "from" email from your patch.
It would be nice if you could fix your workflow (I know you well enough
to know what is your gmail address, but not having to fix this by hand
would be preferable)

Applied to hid/hid.git (for-6.5/wacom), thanks!

[1/1] HID: wacom: Use ktime_t rather than int when dealing with timestamps
      https://git.kernel.org/hid/hid/c/9a6c0e28e215

Cheers,
-- 
Benjamin Tissoires <bentiss@...nel.org>