linux-kernel - Re: [RFC PATCH 1/8] rust: kernel: add basic abstractions for device-mapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c720663e-8743-956d-2ece-c9ca23f94d3a@antgroup.com>
Date:   Mon, 26 Jun 2023 11:26:12 +0800
From:   "Qingsong Chen" <changxian.cqs@...group.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     <linux-kernel@...r.kernel.org>,
        "田洪亮" <tate.thl@...group.com>,
        "Miguel Ojeda" <ojeda@...nel.org>,
        "Alex Gaynor" <alex.gaynor@...il.com>,
        "Wedson Almeida Filho" <wedsonaf@...il.com>,
        "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
        "Björn Roy Baron" <bjorn3_gh@...tonmail.com>,
        "Benno Lossin" <benno.lossin@...ton.me>,
        "Martin Rodriguez Reboredo" <yakoyoku@...il.com>,
        "Alice Ryhl" <aliceryhl@...gle.com>,
        "Vincenzo Palazzo" <vincenzopalazzodev@...il.com>,
        "Asahi Lina" <lina@...hilina.net>, <rust-for-linux@...r.kernel.org>
Subject: Re: [RFC PATCH 1/8] rust: kernel: add basic abstractions for
 device-mapper

On 6/25/23 8:25 PM, Greg KH wrote:
> Shouldn't this be all different commits, and different files?  A bio
> shouldn't be defined in the device_mapper.rs file, as that would prevent
> anyone else from accessing it.

Yes, you're right. Since we noticed that some block layer patches[1]
are under review, we don't put much effort into that. Actually, we
don't want to include all the `bio` implementation in this patchset,
so it just some dummy codes.

If necessary, a seperate commit could be splited, including things
that do not belong to the device mapper.

[1]: 
https://lore.kernel.org/rust-for-linux/20230503090708.2524310-5-nmi@metaspace.dk/

Thanks,
Qingsong Chen