[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4c421206-39a2-d98e-f75d-f5d269e881ff@linaro.org>
Date: Mon, 26 Jun 2023 17:33:57 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Hal Feng <hal.feng@...rfivetech.com>,
Mark Brown <broonie@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor@...nel.org>,
Walker Chen <walker.chen@...rfivetech.com>,
Xingyu Wu <xingyu.wu@...rfivetech.com>,
Emil Renner Berthing <emil.renner.berthing@...onical.com>
Cc: alsa-devel@...a-project.org, devicetree@...r.kernel.org,
linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/5] ASoC: codecs: Add StarFive JH7110 dummy PWM-DAC
transmitter driver
On 26/06/2023 13:09, Hal Feng wrote:
> Add a dummy transmitter driver for StarFive JH7110 PWM-DAC module.
> StarFive JH7110 PWM-DAC controller uses this driver.
>
> Signed-off-by: Hal Feng <hal.feng@...rfivetech.com>
> ---
> sound/soc/codecs/Kconfig | 4 ++
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/jh7110_pwmdac_transmitter.c | 74 ++++++++++++++++++++
> 3 files changed, 80 insertions(+)
> create mode 100644 sound/soc/codecs/jh7110_pwmdac_transmitter.c
>
...
> +
> +static struct platform_driver pwmdac_dit_driver = {
> + .probe = pwmdac_dit_probe,
> + .driver = {
> + .name = DRV_NAME,
> + .of_match_table = of_match_ptr(pwmdac_dit_dt_ids),
> + },
> +};
> +
> +module_platform_driver(pwmdac_dit_driver);
> +
> +MODULE_DESCRIPTION("StarFive JH7110 dummy PWM-DAC transmitter driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:" DRV_NAME);
Drop. You don't need it. If you need it, it means you miss proper ID table.
Best regards,
Krzysztof
Powered by blists - more mailing lists