[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230626163621.GA104@W11-BEAU-MD.localdomain>
Date: Mon, 26 Jun 2023 09:36:21 -0700
From: Beau Belgrave <beaub@...ux.microsoft.com>
To: sunliming <sunliming@...inos.cn>
Cc: rostedt@...dmis.org, mhiramat@...nel.org,
linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v4 0/3] tracing/user_events: Fix incorrect return value
for writes when events are disabled and add its tests
On Mon, Jun 26, 2023 at 07:13:41PM +0800, sunliming wrote:
> Now the writing operation return the count of writes regardless of whether
> events are enabled or disabled. Fix this by just return -EBADF when events
> are disabled.
>
> v3 -> v4:
> - Change the return value from zero to -EBADF
>
Applied these locally, ran a few tests. This looks good to me.
Acked-by: Beau Belgrave <beaub@...ux.microsoft.com>
Thanks,
-Beau
> v2 -> v3:
> - Change the return value from -ENOENT to zero
>
> v1 -> v2:
> - Change the return value from -EFAULT to -ENOENT
>
> sunliming (3):
> tracing/user_events: Fix incorrect return value for writing operation
> when events are disabled
> selftests/user_events: Enable the event before write_fault test in
> ftrace self-test
> selftests/user_events: Add test cases when event is disabled
>
> kernel/trace/trace_events_user.c | 3 ++-
> tools/testing/selftests/user_events/ftrace_test.c | 8 ++++++++
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> --
> 2.25.1
Powered by blists - more mailing lists