[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <743b4c1f-6c46-6d5d-24e9-b286d021389b@gmail.com>
Date: Mon, 26 Jun 2023 13:49:35 -0300
From: Martin Rodriguez Reboredo <yakoyoku@...il.com>
To: Qingsong Chen <changxian.cqs@...group.com>,
linux-kernel@...r.kernel.org
Cc: 田洪亮 <tate.thl@...group.com>,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Wedson Almeida Filho <wedsonaf@...il.com>,
Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
Sergio González Collado <sergio.collado@...il.com>,
rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 1/1] rust: macros: fix redefine const_name in `vtable`
On 6/26/23 04:42, Qingsong Chen wrote:
> If the trait has same function name, the `vtable` macro
> will redefine its `gen_const_name`, e.g.:
> ```rust
> #[vtable]
> pub trait Foo {
> #[cfg(CONFIG_X)]
> fn bar();
>
> #[cfg(not(CONFIG_X))]
> fn bar(x: usize);
> }
> ```
> Use `HashSet` to avoid this.
>
> Signed-off-by: Qingsong Chen <changxian.cqs@...group.com>
> ---
> [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@...il.com>
Powered by blists - more mailing lists