linux-kernel - Re: [PATCH 02/11] arm64: dts: qcom: msm8939: Drop "qcom,idle-state-spc" compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30944ea8-d4aa-d0fd-7eaa-64b59e32eb6b@squareup.com>
Date:   Tue, 27 Jun 2023 10:54:55 -0700
From:   Benjamin Li <benl@...areup.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        cros-qcom-dts-watchers@...omium.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        James Willcox <jwillcox@...areup.com>,
        Joseph Gates <jgates@...areup.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Zac Crosby <zac@...areup.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Banajit Goswami <bgoswami@...cinc.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Lee Jones <lee@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Xu Yang <xu.yang_2@....com>, Peng Fan <peng.fan@....com>,
        Christian Marangi <ansuelsmth@...il.com>,
        Wesley Cheng <quic_wcheng@...cinc.com>,
        Jun Nie <jun.nie@...aro.org>, Max Chen <mchen@...areup.com>,
        Shawn Guo <shawn.guo@...aro.org>,
        Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vincent Knecht <vincent.knecht@...loo.org>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        alsa-devel@...a-project.org, iommu@...ts.linux.dev,
        linux-usb@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Leo Yan <leo.yan@...aro.org>, Rob Herring <robh@...nel.org>,
        Andy Gross <andy.gross@...aro.org>
Subject: Re: [PATCH 02/11] arm64: dts: qcom: msm8939: Drop
 "qcom,idle-state-spc" compatible

On 6/27/23 9:24 AM, Konrad Dybcio wrote:
> As of today, the only cool and legal way to get ARM64 SMP going is
> via PSCI (or spin tables). Sadly, not all chip and device vendors were
> considerate of this in the early days of arm64. Qualcomm, for example
> reused their tried-and-true spin-up method from MSM8974 and their Krait/
> arm32 Cortex designs.
> 
> MSM8916 supports SMP with its arm32 dt overlay, as probably could 8939.
> But the arm64 DT should not define non-PSCI SMP or CPUidle stuff.
> 
> Drop the qcom,idle-state-spc compatible (associated with Qualcomm-specific
> CPUIdle) to make the dt checker happy:
> 
> apq8039-t2.dtb: idle-states: cpu-sleep-0:compatible:
> ['qcom,idle-state-spc', 'arm,idle-state'] is too long
> 
> Fixes: 61550c6c156c ("arm64: dts: qcom: Add msm8939 SoC")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Reviewed-by: Benjamin Li <benl@...areup.com>