linux-kernel - Re: [PATCH] perf test: Fix a compile error on pe-file-parsing.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2023 12:34:37 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf test: Fix a compile error on pe-file-parsing.c

On Tue, Jun 27, 2023 at 7:56 AM Ian Rogers <irogers@...gle.com> wrote:
>
> On Mon, Jun 26, 2023 at 11:33 PM Namhyung Kim <namhyung@...nel.org> wrote:
> >
> > The dso__find_symbol_by_name() should be have idx pointer argument.
> > Found during the build-test.
> >
> >   $ make build-test
> >   ...
> >     CC      /tmp/tmp.6JwPK1xbWG/tests/pe-file-parsing.o
> >   tests/pe-file-parsing.c: In function ‘run_dir’:
> >   tests/pe-file-parsing.c:64:15: error: too few arguments to function ‘dso__find_symbol_by_name’
> >      64 |         sym = dso__find_symbol_by_name(dso, "main");
> >         |               ^~~~~~~~~~~~~~~~~~~~~~~~
> >   In file included from tests/pe-file-parsing.c:16:
> >   /usr/local/google/home/namhyung/project/linux/tools/perf/util/symbol.h:135:16: note: declared here
> >     135 | struct symbol *dso__find_symbol_by_name(struct dso *dso, const char *name, size_t *idx);
> >         |                ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Fixes: 259dce914e93 ("perf symbol: Remove symbol_name_rb_node")
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>
> Acked-by: Ian Rogers <irogers@...gle.com>

Applied to perf-tools-next, thanks!