linux-kernel - Re: [PATCH v1] intel_idle: Add __init annotation to matchup_vm_state_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2280b4a-57cb-41ce-5208-c46492a1bf26@infradead.org>
Date:   Tue, 27 Jun 2023 13:06:16 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>,
        Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [PATCH v1] intel_idle: Add __init annotation to
 matchup_vm_state_with_baremetal()



On 6/27/23 10:50, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> The caller of (recently added) matchup_vm_state_with_baremetal() is an
> __init function and it uses some __initdata data structures, so add the
> __init annotation to it for consistency.
> 
> This addresses the following build warnings:
> 
> WARNING: modpost: vmlinux: section mismatch in reference: matchup_vm_state_with_baremetal+0x51 (section: .text) -> intel_idle_max_cstate_reached (section: .init.text)
> WARNING: modpost: vmlinux: section mismatch in reference: matchup_vm_state_with_baremetal+0x62 (section: .text) -> cpuidle_state_table (section: .init.data)
> WARNING: modpost: vmlinux: section mismatch in reference: matchup_vm_state_with_baremetal+0x79 (section: .text) -> icpu (section: .init.data)
> 
> Fixes: 0fac214bb75e ("intel_idle: Add a "Long HLT" C1 state for the VM guest mode")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Tested-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/idle/intel_idle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/idle/intel_idle.c
> ===================================================================
> --- linux-pm.orig/drivers/idle/intel_idle.c
> +++ linux-pm/drivers/idle/intel_idle.c
> @@ -2147,7 +2147,7 @@ static void __init intel_idle_cpuidle_de
>   * All our short idle states are dominated by vmexit/vmenter latencies,
>   * not the underlying hardware latencies so we keep our values for these.
>   */
> -static void matchup_vm_state_with_baremetal(void)
> +static void __init matchup_vm_state_with_baremetal(void)
>  {
>  	int cstate;
>  
> 
> 
> 

-- 
~Randy