linux-kernel - Re: [PATCH v2] Sched/fair: Block nohz tick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202306280536.Zd5x1Zdv-lkp@intel.com>
Date:   Wed, 28 Jun 2023 05:19:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Phil Auld <pauld@...hat.com>, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, Juri Lelli <juri.lelli@...hat.com>,
        Ingo Molnar <mingo@...hat.com>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Valentin Schneider <vschneid@...hat.com>,
        Ben Segall <bsegall@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Mel Gorman <mgorman@...e.de>, Phil Auld <pauld@...hat.com>
Subject: Re: [PATCH v2] Sched/fair: Block nohz tick_stop when cfs bandwidth
 in use

Hi Phil,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/auto-latest]
[also build test WARNING on linus/master v6.4 next-20230627]
[cannot apply to tip/sched/core tip/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Phil-Auld/Sched-fair-Block-nohz-tick_stop-when-cfs-bandwidth-in-use/20230628-031312
base:   tip/auto-latest
patch link:    https://lore.kernel.org/r/20230627191201.344110-1-pauld%40redhat.com
patch subject: [PATCH v2] Sched/fair: Block nohz tick_stop when cfs bandwidth in use
config: nios2-randconfig-r035-20230627 (https://download.01.org/0day-ci/archive/20230628/202306280536.Zd5x1Zdv-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230628/202306280536.Zd5x1Zdv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306280536.Zd5x1Zdv-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/sched/fair.c:688:5: warning: no previous prototype for 'sched_update_scaling' [-Wmissing-prototypes]
     688 | int sched_update_scaling(void)
         |     ^~~~~~~~~~~~~~~~~~~~
>> kernel/sched/fair.c:6220:6: warning: no previous prototype for 'sched_cfs_bandwidth_active' [-Wmissing-prototypes]
    6220 | bool sched_cfs_bandwidth_active(struct cfs_rq *cfs_rq)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/sched_cfs_bandwidth_active +6220 kernel/sched/fair.c

  6212	
  6213	static inline struct cfs_bandwidth *tg_cfs_bandwidth(struct task_group *tg)
  6214	{
  6215		return NULL;
  6216	}
  6217	static inline void destroy_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
  6218	static inline void update_runtime_enabled(struct rq *rq) {}
  6219	static inline void unthrottle_offline_cfs_rqs(struct rq *rq) {}
> 6220	bool sched_cfs_bandwidth_active(struct cfs_rq *cfs_rq)
  6221	{
  6222		return false;
  6223	}
  6224	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki