linux-kernel - Re: [PATCH] zonefs: do not use append if device does not support it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJpbUShJUL788r7u@infradead.org>
Date:   Mon, 26 Jun 2023 20:45:21 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Andreas Hindborg <nmi@...aspace.dk>
Cc:     Damien Le Moal <dlemoal@...nel.org>,
        "open list:ZONEFS FILESYSTEM" <linux-fsdevel@...r.kernel.org>,
        gost.dev@...sung.com, Andreas Hindborg <a.hindborg@...sung.com>,
        Naohiro Aota <naohiro.aota@....com>,
        Johannes Thumshirn <jth@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] zonefs: do not use append if device does not support it

On Mon, Jun 26, 2023 at 06:47:52PM +0200, Andreas Hindborg wrote:
> From: "Andreas Hindborg (Samsung)" <nmi@...aspace.dk>
> 
> Zonefs will try to use `zonefs_file_dio_append()` for direct sync writes even if
> device `max_zone_append_sectors` is zero. This will cause the IO to fail as the
> io vector is truncated to zero. It also causes a call to
> `invalidate_inode_pages2_range()` with end set to UINT_MAX, which is probably
> not intentional. Thus, do not use append when device does not support it.

How do you even manage to hit this code?  Zone Append is a mandatory
feature and driver need to check it is available.