linux-kernel - Re: [PATCH v3 5/9] cgroup/cpuset: Add cpuset.cpus.exclusive for v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202306271214.Vd5UDf4Y-lkp@intel.com>
Date:   Tue, 27 Jun 2023 12:12:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Waiman Long <longman@...hat.com>, Tejun Heo <tj@...nel.org>,
        Zefan Li <lizefan.x@...edance.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Jonathan Corbet <corbet@....net>,
        Shuah Khan <skhan@...uxfoundation.org>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        cgroups@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kselftest@...r.kernel.org,
        Juri Lelli <juri.lelli@...hat.com>,
        Valentin Schneider <vschneid@...hat.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Mrunal Patel <mpatel@...hat.com>,
        Ryan Phillips <rphillips@...hat.com>,
        Brent Rowsell <browsell@...hat.com>,
        Peter Hunt <pehunt@...hat.com>, Phil Auld <pauld@...hat.com>,
        Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v3 5/9] cgroup/cpuset: Add cpuset.cpus.exclusive for v2

Hi Waiman,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20230626]
[also build test ERROR on v6.4]
[cannot apply to tj-cgroup/for-next linus/master v6.4 v6.4-rc7 v6.4-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Waiman-Long/cgroup-cpuset-Inherit-parent-s-load-balance-state-in-v2/20230627-090025
base:   next-20230626
patch link:    https://lore.kernel.org/r/20230627005529.1564984-6-longman%40redhat.com
patch subject: [PATCH v3 5/9] cgroup/cpuset: Add cpuset.cpus.exclusive for v2
config: s390-defconfig (https://download.01.org/0day-ci/archive/20230627/202306271214.Vd5UDf4Y-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230627/202306271214.Vd5UDf4Y-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306271214.Vd5UDf4Y-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/cgroup/cpuset.c: In function 'cpu_exclusive_check':
>> kernel/cgroup/cpuset.c:699:15: error: assignment to expression with array type
     699 |         cpus1 = cpumask_empty(cs1->exclusive_cpus)
         |               ^
   kernel/cgroup/cpuset.c:701:15: error: assignment to expression with array type
     701 |         cpus2 = cpumask_empty(cs2->exclusive_cpus)
         |               ^


vim +699 kernel/cgroup/cpuset.c

   689	
   690	/*
   691	 * cpu_exclusive_check() - check if two cpusets are exclusive
   692	 *
   693	 * Return 0 if exclusive, -EINVAL if not
   694	 */
   695	static inline bool cpu_exclusive_check(struct cpuset *cs1, struct cpuset *cs2)
   696	{
   697		cpumask_var_t cpus1, cpus2;
   698	
 > 699		cpus1 = cpumask_empty(cs1->exclusive_cpus)
   700			? cs1->cpus_allowed : cs1->exclusive_cpus;
   701		cpus2 = cpumask_empty(cs2->exclusive_cpus)
   702			? cs2->cpus_allowed : cs2->exclusive_cpus;
   703	
   704		if (cpumask_intersects(cpus1, cpus2))
   705			return -EINVAL;
   706		return 0;
   707	}
   708	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki