linux-kernel - Re: [PATCH v2] block: add check that partition length needs to be aligned with block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7a3329f-b66e-1de0-a455-faa29eb214c5@nvidia.com>
Date:   Tue, 27 Jun 2023 04:19:41 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Min Li <min15.li@...sung.com>, "axboe@...nel.dk" <axboe@...nel.dk>,
        "willy@...radead.org" <willy@...radead.org>,
        "hch@....de" <hch@....de>,
        "dlemoal@...nel.org" <dlemoal@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] block: add check that partition length needs to be
 aligned with block size

On 6/27/2023 4:09 AM, Min Li wrote:
> Before calling add partition or resize partition, there is no check
> on whether the length is aligned with the logical block size.
> If the logical block size of the disk is larger than 512 bytes,
> then the partition size maybe not the multiple of the logical block size,
> and when the last sector is read, bio_truncate() will adjust the bio size,
> resulting in an IO error if the size of the read command is smaller than
> the logical block size.If integrity data is supported, this will also
> result in a null pointer dereference when calling bio_integrity_free.
> 
> Signed-off-by: Min Li <min15.li@...sung.com>
> 
> ---
> Changes from v1:
> 
> - Add a space after /* and before */.
> - Move length alignment check before the "start = p.start >> SECTOR_SHIFT"
> - Move check for p.start being aligned together with this length alignment check.
> ---

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck