[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3213e578-1c48-e1bb-f181-d0845f915031@linaro.org>
Date: Tue, 27 Jun 2023 09:44:42 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Yangtao Li <frank.li@...o.com>, miquel.raynal@...tlin.com,
rafael@...nel.org, daniel.lezcano@...aro.org, amitk@...nel.org,
rui.zhang@...el.com, mmayer@...adcom.com,
bcm-kernel-feedback-list@...adcom.com,
florian.fainelli@...adcom.com, shawnguo@...nel.org,
s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
linux-imx@....com, agross@...nel.org, andersson@...nel.org,
konrad.dybcio@...aro.org, thara.gopinath@...il.com,
heiko@...ech.de, mcoquelin.stm32@...il.com,
alexandre.torgue@...s.st.com, thierry.reding@...il.com,
jonathanh@...dia.com, tglx@...utronix.de, matthias.bgg@...il.com,
angelogioacchino.delregno@...labora.com,
srinivas.pandruvada@...ux.intel.com,
DLG-Adam.Ward.opensource@...renesas.com, shangxiaojing@...wei.com,
bchihi@...libre.com, wenst@...omium.org,
u.kleine-koenig@...gutronix.de, hayashi.kunihiko@...ionext.com,
niklas.soderlund+renesas@...natech.se, chi.minghao@....com.cn,
johan+linaro@...nel.org, jernej.skrabec@...il.com
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-arm-msm@...r.kernel.org, linux-rockchip@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com,
linux-tegra@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 13/15] thermal/drivers/rockchip: remove redundant msg
On 27/06/2023 09:40, Krzysztof Kozlowski wrote:
> On 27/06/2023 09:17, Yangtao Li wrote:
>> The upper-layer devm_request_threaded_irq() function can directly
>> print error information.
>
> I don't understand. "Can print"? It does not matter if it can, if it
> does not. Currently it doesn't, therefore change is not correct.
> Otherwise explain a bit better why this is redundant.
All your patches ended up in spam, so now I found your patch one.
Anyway, if this stays, please replace "can" with statement - "prints".
Best regards,
Krzysztof
Powered by blists - more mailing lists