linux-kernel - Re: [PATCH v4 5/9] virt: geniezone: Add irqfd support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <d0bca239-2711-4268-a36c-7c3434982ab1@app.fastmail.com>
Date:   Tue, 27 Jun 2023 11:27:34 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     Yi-De Wu (吳一德) 
        <Yi-De.Wu@...iatek.com>,
        "AngeloGioacchino Del Regno" 
        <angelogioacchino.delregno@...labora.com>,
        "Jonathan Corbet" <corbet@....net>,
        "Catalin Marinas" <catalin.marinas@....com>,
        Yingshiuan Pan (潘穎軒) 
        <Yingshiuan.Pan@...iatek.com>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        Ze-yu Wang (王澤宇) 
        <Ze-yu.Wang@...iatek.com>, "Will Deacon" <will@...nel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        MY Chuang (莊明躍) 
        <MY.Chuang@...iatek.com>, "Trilok Soni" <quic_tsoni@...cinc.com>,
        "Conor.Dooley" <conor.dooley@...rochip.com>,
        PeiLun Suei (隋培倫) 
        <PeiLun.Suei@...iatek.com>,
        Liju-clr Chen (陳麗如) 
        <Liju-clr.Chen@...iatek.com>,
        Jades Shih (施向玨) 
        <jades.shih@...iatek.com>, "Conor Dooley" <conor+dt@...nel.org>,
        "dbrazdil@...gle.com" <dbrazdil@...gle.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Hsiao (蕭志祥) 
        <shawn.hsiao@...iatek.com>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        Ivan Tseng (曾志軒) 
        <ivan.tseng@...iatek.com>,
        Chi-shen Yeh (葉奇軒) 
        <Chi-shen.Yeh@...iatek.com>
Subject: Re: [PATCH v4 5/9] virt: geniezone: Add irqfd support

On Tue, Jun 27, 2023, at 09:54, Yi-De Wu (吳一德) wrote:

>> ..snip.. 
>> > diff --git a/drivers/virt/geniezone/gzvm_main.c b/drivers/virt/geniezone/gzvm_main.c > index 230970cb0953..e62c046d76b3 100644 > --- a/drivers/virt/geniezone/gzvm_main.c > +++ b/drivers/virt/geniezone/gzvm_main.c > @@ -113,11 +113,12 @@ static int gzvm_drv_probe(void) >   return ret; >   gzvm_debug_dev = &gzvm_dev; >   > -return 0; > +return gzvm_drv_irqfd_init(); 
>> ret = gzvm_drv_irqfd_init(); if (ret) return ret; 

Something went wrong with the quoting up here, please make sure to
use plaintext email instead of html.

>> return 0; 
>
> We're wondering the pros and cons for this coding style.
> Could you kindly give us some hint for possibly we could miss it somewhere.
>
> Some other suggestion had been made by AOSP reviewer on the very line 
> mentioned. As a consequence, we'd like to dig in the rationale behind 
> such debate.
> https://android-review.googlesource.com/c/kernel/common/+/2574178/comment/f23bbd52_e3b14396/

I think most developers prefer the shorter form here, and I've
seen cleanup patches actually changing the longer version to that.

     Arnd