linux-kernel - Re: [patch 11/45] posix-cpu-timers: Remove incorrect comment in posix_cpu_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2023 12:30:03 +0200
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Anna-Maria Behnsen <anna-maria@...utronix.de>,
        John Stultz <jstultz@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Eric Biederman <ebiederm@...ssion.com>,
        Oleg Nesterov <oleg@...hat.com>
Subject: Re: [patch 11/45] posix-cpu-timers: Remove incorrect comment in
 posix_cpu_timer_set()

On Tue, Jun 06, 2023 at 04:37:36PM +0200, Thomas Gleixner wrote:
> A leftover from historical code which describes fiction.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

Reviewed-by: Frederic Weisbecker <frederic@...nel.org>


> ---
>  kernel/time/posix-cpu-timers.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -704,13 +704,8 @@ static int posix_cpu_timer_set(struct k_
>  		}
>  	}
>  
> +	/* Retry if the timer expiry is running concurrently */
>  	if (unlikely(ret)) {
> -		/*
> -		 * We are colliding with the timer actually firing.
> -		 * Punt after filling in the timer's old value, and
> -		 * disable this firing since we are already reporting
> -		 * it as an overrun (thanks to bump_cpu_timer above).
> -		 */
>  		unlock_task_sighand(p, &flags);
>  		goto out;
>  	}
>