linux-kernel - Re: [PATCH 08/24] init: pass root_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Jun 2023 03:38:50 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Mike Snitzer <snitzer@...nel.org>,
        Joern Engel <joern@...ybastard.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Pavel Machek <pavel@....cz>,
        Loic Poulain <loic.poulain@...aro.org>, dm-devel@...hat.com,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 08/24] init: pass root_device_name explicitly

On Mon, Jun 26, 2023 at 8:10 AM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On 6/26/23 00:53, Christoph Hellwig wrote:
> > On Fri, Jun 23, 2023 at 05:08:59PM -0700, Guenter Roeck wrote:
> >> Hi,
> >>
> >> On Wed, May 31, 2023 at 02:55:19PM +0200, Christoph Hellwig wrote:
> >>> Instead of declaring root_device_name as a global variable pass it as an
> >>> argument to the functions using it.
> >>>
> >>> Signed-off-by: Christoph Hellwig <hch@....de>
> >>
> >> This patch results in the following build error when trying to build
> >> xtensa:tinyconfig.
> >>
> >> WARNING: modpost: vmlinux: section mismatch in reference: strcpy.isra.0+0x14 (section: .text.unlikely) -> initcall_level_names (section: .init.data)
> >> ERROR: modpost: Section mismatches detected.
> >
> > I can reproduce these with gcc 13.1 on xtensa, but the report makes
> > no sense to me.  If I disable CONFIG_CC_OPTIMIZE_FOR_SIZE it now reports
> > a similar warning for put_page intead of strcpy which seems just as
> > arcance.
> >
>
> I don't see that (I tried 11.3, 11.4, 12.3, and 13.1), but then I am not sure
> if this is worth tracking down. I just force CONFIG_SECTION_MISMATCH_WARN_ONLY=y
> for xtensa builds instead.

I believe it's yet another manifestation of the following issue:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92938

Hunting is still on my todo list, but it's quite low, so I guess
forcing CONFIG_SECTION_MISMATCH_WARN_ONLY=y for xtensa
is the right thing to do for now.

-- 
Thanks.
-- Max