linux-kernel - [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230627113808.269716-1-korantwork@gmail.com>
Date:   Tue, 27 Jun 2023 19:38:08 +0800
From:   korantwork@...il.com
To:     kw@...ux.com, nirmal.patel@...ux.intel.com
Cc:     linux-kernel@...r.kernel.org, hch@...radead.org,
        linux-pci@...r.kernel.org, Xinghui Li <korantli@...cent.com>,
        Dan Carpenter <error27@...il.com>
Subject: [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch

From: Xinghui Li <korantli@...cent.com>

There is one inconsistent indenting warning:
"drivers/pci/controller/vmd.c:1058 vmd_resume()
warn: inconsistent indenting"

Fix it and remove the unnecessary if.

Reported-by: Dan Carpenter <error27@...il.com>
Signed-off-by: Christoph Hellwig <hch@...radead.org>
Signed-off-by: Xinghui Li <korantli@...cent.com>
---
 drivers/pci/controller/vmd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 990630ec57c6..356bbeb548fe 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -1055,10 +1055,7 @@ static int vmd_resume(struct device *dev)
 	struct vmd_dev *vmd = pci_get_drvdata(pdev);
 	int err, i;
 
-       if (vmd->irq_domain)
-               vmd_set_msi_remapping(vmd, true);
-       else
-               vmd_set_msi_remapping(vmd, false);
+	vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
 
 	for (i = 0; i < vmd->msix_count; i++) {
 		err = devm_request_irq(dev, vmd->irqs[i].virq,
-- 
2.39.3