linux-kernel - [PATCH] scripts/gdb: Fix importing SB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230627124332.82758-1-jackmanb@google.com>
Date:   Tue, 27 Jun 2023 12:43:32 +0000
From:   Brendan Jackman <jackmanb@...gle.com>
To:     linux-kernel@...r.kernel.org
Cc:     jan.kiszka@...mens.com, kbingham@...nel.org, f.fainelli@...il.com,
        akpm@...ux-foundation.org, jackmanb@...gle.com,
        p.raghav@...sung.com, mcgrof@...nel.org
Subject: [PATCH] scripts/gdb: Fix importing SB_ constants

Commit f15afbd34d8f ("fs: fix undefined behavior in bit shift for
SB_NOUSER") switched these defines over to use BIT which when,
!__ASSEMBLY__, expands to something equivalent to 1UL << x. The UL
suffix isn't valid python.

Luckily we already seem to have a facility in the preprocessed code to
handle cases like this.

Signed-off-by: Brendan Jackman <jackmanb@...gle.com>
---
 scripts/gdb/linux/constants.py.in | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
index 471300ba176c..50a92c4e9984 100644
--- a/scripts/gdb/linux/constants.py.in
+++ b/scripts/gdb/linux/constants.py.in
@@ -48,12 +48,12 @@ if IS_BUILTIN(CONFIG_COMMON_CLK):
     LX_GDBPARSED(CLK_GET_RATE_NOCACHE)
 
 /* linux/fs.h */
-LX_VALUE(SB_RDONLY)
-LX_VALUE(SB_SYNCHRONOUS)
-LX_VALUE(SB_MANDLOCK)
-LX_VALUE(SB_DIRSYNC)
-LX_VALUE(SB_NOATIME)
-LX_VALUE(SB_NODIRATIME)
+LX_GDBPARSED(SB_RDONLY)
+LX_GDBPARSED(SB_SYNCHRONOUS)
+LX_GDBPARSED(SB_MANDLOCK)
+LX_GDBPARSED(SB_DIRSYNC)
+LX_GDBPARSED(SB_NOATIME)
+LX_GDBPARSED(SB_NODIRATIME)
 
 /* linux/htimer.h */
 LX_GDBPARSED(hrtimer_resolution)
-- 
2.41.0.162.gfafddb0af9-goog