linux-kernel - Re: [PATCH] OPP: Properly propagate error along when failing to get icc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230627020547.pek7ld44p4g7lbno@vireshk-i7>
Date:   Tue, 27 Jun 2023 07:35:47 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Andrew Halaney <ahalaney@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        sboyd@...nel.org, nm@...com, vireshk@...nel.org,
        kernel test robot <lkp@...el.com>,
        Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] OPP: Properly propagate error along when failing to get
 icc_path

On 26-06-23, 08:46, Andrew Halaney wrote:
> fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path")
> failed to actually use the error it was trying to log:
> 
>     smatch warnings:
>     drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe'
> 
> Make sure to use the right error and pass it along.
> 
> Fixes: fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/r/202306262008.guNLgjt6-lkp@intel.com/
> Signed-off-by: Andrew Halaney <ahalaney@...hat.com>

Applied. Thanks.

-- 
viresh