[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0815474b-a8fa-f486-fc6e-a85df88ed9b9@linaro.org>
Date: Tue, 27 Jun 2023 15:39:21 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Valentin Caron <valentin.caron@...s.st.com>,
Mark Brown <broonie@...nel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Alain Volmat <alain.volmat@...s.st.com>,
linux-spi@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] spi: stm32: disable device mode with st,stm32f4-spi
compatible
On 27/06/2023 14:39, Valentin Caron wrote:
> STM32 SPI driver is not capable to handle device mode with stm32f4 soc.
> Stop probing if this case happens, and print an error with involved
> compatible.
>
...
>
> static const struct of_device_id stm32_spi_of_match[] = {
> @@ -1798,8 +1802,16 @@ static int stm32_spi_probe(struct platform_device *pdev)
> struct device_node *np = pdev->dev.of_node;
> bool device_mode;
> int ret;
> + const char *compatible =
> + of_match_device(pdev->dev.driver->of_match_table, &pdev->dev)->compatible;
The goal was to replace it, so drop it.
> + const struct stm32_spi_cfg *cfg = (const struct stm32_spi_cfg *)
Why do you need the cast? To drop the const? Are you sure it is really
needed?
> + of_device_get_match_data(&pdev->dev);
Best regards,
Krzysztof
Powered by blists - more mailing lists