linux-kernel - RE: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AS8PR04MB84043AAD5C0C13BB58CCB4349227A@AS8PR04MB8404.eurprd04.prod.outlook.com>
Date:   Tue, 27 Jun 2023 02:23:24 +0000
From:   Sherry Sun <sherry.sun@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        Shenwei Wang <shenwei.wang@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp
 compatible string



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: 2023年6月26日 23:47
> To: Sherry Sun <sherry.sun@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> shawnguo@...nel.org; s.hauer@...gutronix.de; festevam@...il.com;
> Shenwei Wang <shenwei.wang@....com>; gregkh@...uxfoundation.org
> Cc: devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> kernel@...gutronix.de; linux-serial@...r.kernel.org; linux-
> kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH V2 3/3] dt-bindings: serial: fsl-lpuart: add imx8ulp
> compatible string
> 
> On 26/06/2023 06:48, Sherry Sun wrote:
> > Add imx8ulp compatible string in lpuart dt-binding, also correct the
> > imx93 compatible here, imx93/imx8ulp add some new features based on
> > imx7ulp lpuart, so need to add "fsl,imx8ulp-lpuart" for imx93 to
> > enable those new features.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@....com>
> > ---
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 9
> > ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index 93062403276b..272bfbb1cdfc 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -21,12 +21,15 @@ properties:
> >            - fsl,ls1021a-lpuart
> >            - fsl,ls1028a-lpuart
> >            - fsl,imx7ulp-lpuart
> > +          - fsl,imx8ulp-lpuart
> 
> I don't understand this. Commit msg also does not explain this.

Hi Krzysztof,
Thanks for the catch, seems this is not needed as we have the below 8ulp+7ulp entry for this, will remove it in V3.

> 
> >            - fsl,imx8qxp-lpuart
> >            - fsl,imxrt1050-lpuart
> >        - items:
> > -          - enum:
> > -              - fsl,imx93-lpuart
> > -              - fsl,imx8ulp-lpuart
> 
> This could have stayed as enum with one entry which would make your diff
> more readable.
> 
> > +          - const: fsl,imx8ulp-lpuart
> > +          - const: fsl,imx7ulp-lpuart
> 
Sure, will change it to enum, thanks.

Best Regards
Sherry