[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <131c6b50-5f14-9bb7-b5bd-5103f7ccc6eb@loongson.cn>
Date: Tue, 27 Jun 2023 22:40:09 +0800
From: Sui Jingfeng <suijingfeng@...ngson.cn>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Thomas Zimmermann <tzimmermann@...e.de>,
Magnus Damm <magnus.damm@...il.com>
Cc: linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [26/39] drm: renesas: shmobile: Rename
shmob_drm_connector.connector
On 2023/6/22 17:21, Geert Uytterhoeven wrote:
> Rename the "connector" member of the shmob_drm_connector subclass
> structure to "base", to improve readability.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Reviewed-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> ---
> drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 4 ++--
> drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> index 3f0b71253ed929c9..2c0ca802d36026f4 100644
> --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c
> @@ -608,7 +608,7 @@ int shmob_drm_encoder_create(struct shmob_drm_device *sdev)
>
> static inline struct shmob_drm_connector *to_shmob_connector(struct drm_connector *connector)
> {
> - return container_of(connector, struct shmob_drm_connector, connector);
> + return container_of(connector, struct shmob_drm_connector, base);
> }
>
> static int shmob_drm_connector_get_modes(struct drm_connector *connector)
> @@ -669,7 +669,7 @@ shmob_drm_connector_init(struct shmob_drm_device *sdev,
> if (!scon)
> return ERR_PTR(-ENOMEM);
>
> - connector = &scon->connector;
> + connector = &scon->base;
> info = &connector->display_info;
> info->width_mm = sdev->pdata->panel.width_mm;
> info->height_mm = sdev->pdata->panel.height_mm;
> diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.h b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.h
> index 79cce0a0ada4cfce..2c6d7541427581a6 100644
> --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.h
> +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.h
> @@ -33,7 +33,7 @@ struct shmob_drm_crtc {
> };
>
> struct shmob_drm_connector {
> - struct drm_connector connector;
> + struct drm_connector base;
> struct drm_encoder *encoder;
> const struct videomode *mode;
> };
--
Jingfeng
Powered by blists - more mailing lists