linux-kernel - Re: [PATCH v5 00/11] Add dynamic boost control support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJsDg7xl6P8YfaaV@johallen-workstation>
Date:   Tue, 27 Jun 2023 10:42:59 -0500
From:   John Allen <john.allen@....com>
To:     Mario Limonciello <mario.limonciello@....com>
Cc:     Tom Lendacky <thomas.lendacky@....com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v5 00/11] Add dynamic boost control support

On Fri, Jun 23, 2023 at 08:49:50AM -0500, Mario Limonciello wrote:
> Dynamic boost control is a feature of some SoCs that allows
> an authenticated entity to send commands to the security processor
> to control certain SOC characteristics with the intention to improve
> performance.
> 
> This is implemented via a mechanism that a userspace application would
> authenticate using a nonce and key exchange over an IOCTL interface.
> 
> After authentication is complete an application can exchange signed
> messages with the security processor and both ends can validate the
> data transmitted.
> 
> This series includes a test suite that can be run on real hardware
> to ensure that the communication works as expected.  This can also be
> used for an application to model the communication path.
> 
> Two sysfs files are introduced for reading the PSP bootloader version
> as well as TEE version which can be useful data points for debugging
> communication problems.

Series looks OK to me.

Acked-by: John Allen <john.allen@....com>

> 
> v4->v5:
>  * Pick up tags
>  * Pick up a static fix
>  * Fix a mistake found in dbc_cli
> 
> Mario Limonciello (11):
>   crypto: ccp: Rename macro for security attributes
>   crypto: ccp: Add support for displaying PSP firmware versions
>   crypto: ccp: Add bootloader and TEE version offsets
>   crypto: ccp: move setting PSP master to earlier in the init
>   crypto: ccp: Add support for fetching a nonce for dynamic boost
>     control
>   crypto: ccp: Add support for setting user ID for dynamic boost control
>   crypto: ccp: Add support for getting and setting DBC parameters
>   crypto: ccp: Add a sample library for ioctl use
>   crypto: ccp: Add a sample python script for Dynamic Boost Control
>   crypto: ccp: Add unit tests for dynamic boost control
>   crypto: ccp: Add Mario to MAINTAINERS
> 
>  Documentation/ABI/testing/sysfs-driver-ccp |  18 ++
>  MAINTAINERS                                |  12 +
>  drivers/crypto/ccp/Makefile                |   3 +-
>  drivers/crypto/ccp/dbc.c                   | 250 +++++++++++++++++++
>  drivers/crypto/ccp/dbc.h                   |  56 +++++
>  drivers/crypto/ccp/psp-dev.c               |  19 +-
>  drivers/crypto/ccp/psp-dev.h               |   1 +
>  drivers/crypto/ccp/sp-dev.h                |   7 +
>  drivers/crypto/ccp/sp-pci.c                |  96 +++++++-
>  include/linux/psp-platform-access.h        |   4 +
>  include/uapi/linux/psp-dbc.h               | 147 ++++++++++++
>  tools/crypto/ccp/.gitignore                |   1 +
>  tools/crypto/ccp/Makefile                  |  13 +
>  tools/crypto/ccp/dbc.c                     |  72 ++++++
>  tools/crypto/ccp/dbc.py                    |  64 +++++
>  tools/crypto/ccp/dbc_cli.py                | 134 +++++++++++
>  tools/crypto/ccp/test_dbc.py               | 266 +++++++++++++++++++++
>  17 files changed, 1146 insertions(+), 17 deletions(-)
>  create mode 100644 drivers/crypto/ccp/dbc.c
>  create mode 100644 drivers/crypto/ccp/dbc.h
>  create mode 100644 include/uapi/linux/psp-dbc.h
>  create mode 100644 tools/crypto/ccp/.gitignore
>  create mode 100644 tools/crypto/ccp/Makefile
>  create mode 100644 tools/crypto/ccp/dbc.c
>  create mode 100644 tools/crypto/ccp/dbc.py
>  create mode 100755 tools/crypto/ccp/dbc_cli.py
>  create mode 100755 tools/crypto/ccp/test_dbc.py
> 
> 
> base-commit: b335f258e8ddafec0e8ae2201ca78d29ed8f85eb
> -- 
> 2.34.1
>