linux-kernel - Re: [PATCH v3] Bluetooth: btmtk: add printing firmware information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20b61d77-7397-e3ba-3215-232f49eb8c07@molgen.mpg.de>
Date:   Thu, 29 Jun 2023 00:28:15 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Sean Wang <sean.wang@...iatek.com>,
        Chris Lu <chris.lu@...iatek.com>
Cc:     marcel@...tmann.org, johan.hedberg@...il.com, luiz.dentz@...il.com,
        Soul.Huang@...iatek.com, Leon.Yen@...iatek.com,
        Deren.Wu@...iatek.com, km.lin@...iatek.com,
        robin.chiu@...iatek.com, Eddie.Chen@...iatek.com,
        ch.yeh@...iatek.com, jenhao.yang@...iatek.com,
        Stella.Chang@...iatek.com, Tom.Chou@...iatek.com,
        steve.lee@...iatek.com, jsiuda@...gle.com, frankgor@...gle.com,
        abhishekpandit@...gle.com, michaelfsun@...gle.com,
        mmandlik@...gle.com, abhishekpandit@...omium.org,
        mcchou@...omium.org, shawnku@...gle.com,
        linux-bluetooth@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] Bluetooth: btmtk: add printing firmware information

Dear Sean, dear Chris,


Thank you for your patch.

Am 29.06.23 um 00:20 schrieb sean.wang@...iatek.com:
> From: Chris Lu <chris.lu@...iatek.com>
> 
> Add printing firmware information part when driver loading firmware that
> user can get mediatek bluetooth information.

Maybe use the commit message summary/title below:

Bluetooth: btmtk: Log hw/sw version and fw build time

Maybe also paste one log message example to the commit message.

> Co-developed-by: Sean Wang <sean.wang@...iatek.com>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> Signed-off-by: Chris Lu <chris.lu@...iatek.com>
> ---
> v3: resend again with the latest tree
> ---
>   drivers/bluetooth/btmtk.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c
> index 9482401d97fa..8490d59502a5 100644
> --- a/drivers/bluetooth/btmtk.c
> +++ b/drivers/bluetooth/btmtk.c
> @@ -57,6 +57,7 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname,
>   			      wmt_cmd_sync_func_t wmt_cmd_sync)
>   {
>   	struct btmtk_hci_wmt_params wmt_params;
> +	struct btmtk_patch_header *hdr;
>   	struct btmtk_global_desc *globaldesc = NULL;
>   	struct btmtk_section_map *sectionmap;
>   	const struct firmware *fw;
> @@ -75,9 +76,13 @@ int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname,
>   
>   	fw_ptr = fw->data;
>   	fw_bin_ptr = fw_ptr;
> +	hdr = (struct btmtk_patch_header *)fw_ptr;
>   	globaldesc = (struct btmtk_global_desc *)(fw_ptr + MTK_FW_ROM_PATCH_HEADER_SIZE);
>   	section_num = le32_to_cpu(globaldesc->section_num);
>   
> +	bt_dev_info(hdev, "HW/SW Version: 0x%04x%04x, Build Time: %s",

Why not print 0x%04x/0x%04x, that means with a slash?

> +		    le16_to_cpu(hdr->hwver), le16_to_cpu(hdr->swver), hdr->datetime);
> +
>   	for (i = 0; i < section_num; i++) {
>   		first_block = 1;
>   		fw_ptr = fw_bin_ptr;


Kind regards,

Paul