linux-kernel - Re: [PATCH v8 5/5] staging: vc04_services: vchiq_arm: Remove vchiq_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2023 23:46:52 +0100
From:   Kieran Bingham <kieran.bingham@...asonboard.com>
To:     Umang Jain <umang.jain@...asonboard.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-staging@...ts.linux.dev
Cc:     stefan.wahren@...e.com, gregkh@...uxfoundation.org,
        f.fainelli@...il.com, athierry@...hat.com, error27@...il.com,
        dave.stevenson@...pberrypi.com, laurent.pinchart@...asonboard.com,
        Umang Jain <umang.jain@...asonboard.com>
Subject: Re: [PATCH v8 5/5] staging: vc04_services: vchiq_arm: Remove vchiq_register_child()

Quoting Umang Jain (2023-06-27 21:16:28)
> vchiq_register_child() is used to registered child devices as platform

s/registered/register/

> devices. Now that the child devices are migrated to use the
> vchiq_bus_type instead, they will be registered to that. Hence, drop
> vchiq_register_child() as it is no more required.
> 

Reviewed-by: Kieran Bingham <kieran.bingham@...asonboard.com>

> Signed-off-by: Umang Jain <umang.jain@...asonboard.com>
> ---
>  .../interface/vchiq_arm/vchiq_arm.c           | 22 -------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index 75da37fa6372..3c52b09c49ea 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -1778,28 +1778,6 @@ static const struct of_device_id vchiq_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, vchiq_of_match);
>  
> -static struct platform_device *
> -vchiq_register_child(struct platform_device *pdev, const char *name)
> -{
> -       struct platform_device_info pdevinfo;
> -       struct platform_device *child;
> -
> -       memset(&pdevinfo, 0, sizeof(pdevinfo));
> -
> -       pdevinfo.parent = &pdev->dev;
> -       pdevinfo.name = name;
> -       pdevinfo.id = PLATFORM_DEVID_NONE;
> -       pdevinfo.dma_mask = DMA_BIT_MASK(32);
> -
> -       child = platform_device_register_full(&pdevinfo);
> -       if (IS_ERR(child)) {
> -               dev_warn(&pdev->dev, "%s not registered\n", name);
> -               child = NULL;
> -       }
> -
> -       return child;
> -}
> -
>  static int vchiq_probe(struct platform_device *pdev)
>  {
>         struct device_node *fw_node;
> -- 
> 2.39.1
>